Page MenuHomePhabricator
Differential D3047

Move RPC registration out of AppInitParameterInteraction
ClosedPublic
Actions

Authored by deadalnix on May 14 2019, 22:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING24718b29dbf7: Move RPC registration out of AppInitParameterInteraction
rABC24718b29dbf7: Move RPC registration out of AppInitParameterInteraction
Summary

Move to AppInitServers. This doesn't have any effects on bitcoin behavior. It
was just strange to have this unrelated code in the middle or parameter
interaction.

This is a backport of Core PR11603 + a bunch of scafolding due to difference in codebases

Depends on D3046

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11603
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5852
Build 9764: Bitcoin ABC Buildbot (legacy)
Build 9763: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 14 2019, 22:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 22:31
teamcity added a comment.May 14 2019, 22:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 14 2019, 22:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5852: Diff 8664!May 14 2019, 22:33
deadalnix added a child revision: D3048: wallet: Refactor g_wallet_init_interface to const reference.May 14 2019, 22:40
deadalnix updated this revision to Diff 8667.May 14 2019, 22:46

Fix initial diff broken due to DDoS

teamcity added a comment.May 14 2019, 22:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 14 2019, 23:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5855: Diff 8667.May 14 2019, 23:01
deadalnix updated this revision to Diff 8688.May 16 2019, 11:47

Reup fubared diff

teamcity added a comment.May 16 2019, 11:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.May 16 2019, 11:56
This revision is now accepted and ready to land.May 16 2019, 11:56
teamcity added a comment.May 16 2019, 12:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5868: Diff 8688.May 16 2019, 12:02
Closed by commit rABC24718b29dbf7: Move RPC registration out of AppInitParameterInteraction (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyMay 16 2019, 12:34
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING24718b29dbf7: Move RPC registration out of AppInitParameterInteraction.Sep 18 2019, 23:33

Revision Contents
Changeset List

PathSize
src/
4 lines
4 lines
14 lines
interfaces/
4 lines
9 lines
qt/
27 lines

Diff 8664

View Options

src/bitcoind.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...