[qa] Delete cookie file before starting node
ClosedPublic
Actions

Authored by Fabien on May 21 2019, 12:46.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING518bcf2a7c9f: [qa] Delete cookie file before starting node
rABC518bcf2a7c9f: [qa] Delete cookie file before starting node

Summary

If a cookie file exists in a datadir prior to node startup, it must have
been leftover from a prior unclean shutdown. As bitcoind will overwrite
it anyway, delete it before starting up to prevent the test framework
from inadvertently trying to connect using stale credentials.

Backport of core PR12902
https://github.com/bitcoin/bitcoin/pull/12902/files

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12902

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5923
Build 9906: Bitcoin ABC Buildbot (legacy)
Build 9905: arc lint + arc unit

Event Timeline

Fabien created this revision.May 21 2019, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2019, 12:46

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5923: Diff 8776.May 21 2019, 13:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 21 2019, 23:32

This revision is now accepted and ready to land.May 21 2019, 23:32

Closed by commit rABC518bcf2a7c9f: [qa] Delete cookie file before starting node (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by Fabien). · Explain WhyMay 22 2019, 09:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC518bcf2a7c9f: [qa] Delete cookie file before starting node.

Fabien added a commit: rSTAGING518bcf2a7c9f: [qa] Delete cookie file before starting node.Sep 18 2019, 23:40

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_node.py

5 lines

util.py

7 lines

Diff 8776

View Options

test/functional/test_framework/test_node.py