Fix for mismatched extern definition in wallet test
ClosedPublic
Actions

Authored by Fabien on May 23 2019, 12:46.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGdd95502a5800: Fix for mismatched extern definition in wallet test
rABCdd95502a5800: Fix for mismatched extern definition in wallet test

Summary

The extern declarations are using a raw pointer which doesn't match the
source variable's std::unqiue_ptr.

Backport of core PR11713
https://github.com/bitcoin/bitcoin/pull/11713/files

Completes T660

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11713

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5952
Build 9964: Bitcoin ABC Buildbot (legacy)
Build 9963: arc lint + arc unit

Event Timeline

Fabien created this revision.May 23 2019, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2019, 12:46

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5952: Diff 8820.May 23 2019, 13:02

Fabien added a child revision: D3098: tests: move pwalletMain to wallet test fixture.May 23 2019, 13:04

deadalnix accepted this revision.May 23 2019, 15:22

This revision is now accepted and ready to land.May 23 2019, 15:22

Closed by commit rABCdd95502a5800: Fix for mismatched extern definition in wallet test (authored by Aaron Clauson <aaron@sipsorcery.com>, committed by Fabien). · Explain WhyMay 23 2019, 15:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdd95502a5800: Fix for mismatched extern definition in wallet test.

Fabien added a commit: rSTAGINGdd95502a5800: Fix for mismatched extern definition in wallet test.Sep 18 2019, 23:42

Revision Contents
Changeset List

Path

Size

src/

wallet/

test/

accounting_tests.cpp

2 lines

wallet_tests.cpp

2 lines

Diff 8820

View Options

src/wallet/test/accounting_tests.cpp