Page MenuHomePhabricator
Differential D3099

Refactor walletdb_tests to use the wallet test fixture
ClosedPublic
Actions

Authored by Fabien on May 23 2019, 14:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1b5292777d9f: Refactor walletdb_tests to use the wallet test fixture
rABC1b5292777d9f: Refactor walletdb_tests to use the wallet test fixture
Summary

The src/wallet/test/walletdb_tests.cpp test file defines its own test
fixture, which is equivalent to a subset of the WalletTestingSetup
from src/wallet/test/wallet_test_fixture.h.
Using the WalletTestingSetup will reduce maintenance cost.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 23 2019, 14:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2019, 14:15
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 23 2019, 14:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 23 2019, 14:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5954: Diff 8823.May 23 2019, 14:30
Fabien planned changes to this revision.May 23 2019, 14:38
Fabien requested review of this revision.May 23 2019, 14:46
deadalnix accepted this revision.May 23 2019, 15:25
This revision is now accepted and ready to land.May 23 2019, 15:25
Closed by commit rABC1b5292777d9f: Refactor walletdb_tests to use the wallet test fixture (authored by Fabien). · Explain WhyMay 23 2019, 15:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1b5292777d9f: Refactor walletdb_tests to use the wallet test fixture.
Fabien mentioned this in D3102: Don't create another wallet db directory in walletdb_tests.May 24 2019, 10:20
Fabien mentioned this in rABCdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests.May 27 2019, 15:53
Fabien added a commit: rSTAGING1b5292777d9f: Refactor walletdb_tests to use the wallet test fixture.Sep 18 2019, 23:42
Fabien mentioned this in rSTAGINGdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests.Sep 18 2019, 23:49

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
15 lines

Diff 8831

View Options

src/wallet/test/walletdb_tests.cpp

Loading...