Page MenuHomePhabricator
Differential D3121

Abstract out IsSolvable from Witnessifier
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 01:34.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING3c24b5dfffba: Abstract out IsSolvable from Witnessifier
rABC3c24b5dfffba: Abstract out IsSolvable from Witnessifier
Summary

This is extracted from Core PR11403 : https://github.com/bitcoin/bitcoin/pull/11403/commits/0c8ea6380c9f402ed9777fd015b117ba13125a35

We don't have a witnessifier, so the usefulness is limited for us, but it'll help backport the relevent part of PR11403 and we can cleanup after the fact.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
issolvable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5999
Build 10057: Bitcoin ABC Buildbot (legacy)
Build 10056: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2019, 01:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 01:34
teamcity added a comment.May 27 2019, 01:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 01:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5999: Diff 8900.May 27 2019, 01:49
markblundeberg accepted this revision.May 27 2019, 03:53
This revision is now accepted and ready to land.May 27 2019, 03:53
Closed by commit rABC3c24b5dfffba: Abstract out IsSolvable from Witnessifier (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 27 2019, 12:13
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3c24b5dfffba: Abstract out IsSolvable from Witnessifier.
deadalnix added a commit: rSTAGING3c24b5dfffba: Abstract out IsSolvable from Witnessifier.Sep 18 2019, 23:47
markblundeberg added a comment.Jan 12 2020, 11:32

(removed again in D3136)

markblundeberg mentioned this in D4912: Reintroduce IsSolvable.Jan 12 2020, 12:48
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC9dda12ee9286: Reintroduce IsSolvable.Jan 13 2020, 00:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING9dda12ee9286: Reintroduce IsSolvable.Apr 7 2020, 22:23

Revision Contents
Changeset List

PathSize
src/
policy/
6 lines
script/
8 lines
16 lines

Diff 8900

View Options

src/policy/policy.h

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...