Bump wallet version to 190700 and remove the `usehd` option
ClosedPublic
Actions

Authored by Fabien on May 27 2019, 14:48.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf1d4b9f95309: Bump wallet version to 190700 and remove the `usehd` option
rABCf1d4b9f95309: Bump wallet version to 190700 and remove the `usehd` option

Summary

Bump the wallet version number to 190700 so that new wallets made without a default key will no longer work on previous versions at all.
Also remove the usehd option to avoid weird interaction with wallet version numbers and HD-ness of wallets.

Backport of core PR11250 and PR11285
https://github.com/bitcoin/bitcoin/pull/11250/files
https://github.com/bitcoin/bitcoin/pull/11285/files

Test Plan

make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11250

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6019
Build 10097: Bitcoin ABC Buildbot (legacy)
Build 10096: arc lint + arc unit

Event Timeline

Fabien created this revision.May 27 2019, 14:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 14:48

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6009: Diff 8915.May 27 2019, 15:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien planned changes to this revision.May 27 2019, 16:01

Fabien retitled this revision from Remove usehd option and warn when it is used to Bump wallet version to 190700 and remove the `usehd` option.May 27 2019, 16:07

Fabien edited the summary of this revision. (Show Details)

Fix squash

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6019: Diff 8933.May 27 2019, 18:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 27 2019, 20:50

This revision is now accepted and ready to land.May 27 2019, 20:50

Closed by commit rABCf1d4b9f95309: Bump wallet version to 190700 and remove the `usehd` option (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyMay 28 2019, 08:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf1d4b9f95309: Bump wallet version to 190700 and remove the `usehd` option.

Fabien added a commit: rSTAGINGf1d4b9f95309: Bump wallet version to 190700 and remove the `usehd` option.Sep 18 2019, 23:50