Page MenuHomePhabricator
Differential D3154

Give ZMQ consistent order with UpdatedBlockTip on scheduler thread
ClosedPublic
Actions

Authored by deadalnix on May 30 2019, 01:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING17c966b4c03a: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread
rABC17c966b4c03a: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread
Summary

Note that UpdatedBlockTip is also used in net_processing to
announce new blocks to peers. As this may need additional review,
this change is included in its own commit.

This is a partial backport of Core PR10286 : https://github.com/bitcoin/bitcoin/pull/10286/commits/3ea8b75281edc60078423bd5d277cd2a84aa5d33

Test Plan
make check
./test/functional/test_runner.py interface_zmq.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
zmqconsistent
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6065
Build 10179: Bitcoin ABC Buildbot (legacy)
Build 10178: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 30 2019, 01:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2019, 01:08
teamcity added a comment.May 30 2019, 01:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3156: Also call other wallet notify callbacks in scheduler thread.May 30 2019, 01:17
teamcity added a comment.May 30 2019, 01:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6065: Diff 9004.May 30 2019, 01:23
Fabien edited the summary of this revision. (Show Details)May 30 2019, 06:42
Fabien accepted this revision.May 30 2019, 06:58
This revision is now accepted and ready to land.May 30 2019, 06:58
Closed by commit rABC17c966b4c03a: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyMay 30 2019, 12:03
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC17c966b4c03a: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread.
deadalnix added a commit: rSTAGING17c966b4c03a: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread.Sep 18 2019, 23:53

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 9004

View Options

src/validationinterface.cpp

Loading...