[nit] do not capture unused `this` in wallet interface
ClosedPublic
Actions

Authored by schancel on May 31 2019, 07:13.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING30a7f3e07d22: [nit] do not capture unused `this` in wallet interface
rABC30a7f3e07d22: [nit] do not capture unused `this` in wallet interface

Summary

Remove capture of this in lambda within wallet.cpp to fix the following warning:

../../src/interfaces/wallet.cpp:405:22: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
                [fn, this](CWallet *, const TxId &txid, ChangeType status) {

Test Plan

make

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.May 31 2019, 07:13

Owners added a reviewer: Restricted Owners Package.May 31 2019, 07:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2019, 07:13

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6091: Diff 9036.May 31 2019, 07:27

deadalnix accepted this revision.May 31 2019, 07:29

This revision is now accepted and ready to land.May 31 2019, 07:29

Closed by commit rABC30a7f3e07d22: [nit] do not capture unused `this` in wallet interface (authored by schancel). · Explain WhyJun 1 2019, 07:22

This revision was automatically updated to reflect the committed changes.

schancel added a commit: rABC30a7f3e07d22: [nit] do not capture unused `this` in wallet interface.

schancel added a commit: rSTAGING30a7f3e07d22: [nit] do not capture unused `this` in wallet interface.Sep 19 2019, 14:55

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.cpp

2 lines

Diff 9056

View Options

[nit] do not capture unused `this` in wallet interfaceClosedPublicActions