Page MenuHomePhabricator

Remove implicit parameter from GetSerializeSize
ClosedPublic

Authored by deadalnix on Tue, Jun 4, 13:11.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC3a8bd492d2ee: Remove implicit parameter from GetSerializeSize
Summary

Both parameters are integer so we can't rely on the type checker to raise errors.

One such error was present in GetVirtualTransactionSize

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Tue, Jun 4, 13:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jun 4, 13:11
jasonbcox retitled this revision from Remove implcit parameter from GetSerializeSize to Remove implicit parameter from GetSerializeSize.Tue, Jun 4, 20:24
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)Tue, Jun 4, 20:33
jasonbcox accepted this revision.
This revision is now accepted and ready to land.Tue, Jun 4, 20:33
This revision was automatically updated to reflect the committed changes.