Page MenuHomePhabricator
Differential D3195

Remove implicit parameter from GetSerializeSize
ClosedPublic
Actions

Authored by deadalnix on Jun 4 2019, 13:11.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3a8bd492d2ee: Remove implicit parameter from GetSerializeSize
rABC3a8bd492d2ee: Remove implicit parameter from GetSerializeSize
Summary

Both parameters are integer so we can't rely on the type checker to raise errors.

One such error was present in GetVirtualTransactionSize

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
serexplicitparam
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6135
Build 10318: Bitcoin ABC Buildbot (legacy)
Build 10317: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 4 2019, 13:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2019, 13:11
teamcity added a comment.Jun 4 2019, 13:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6135: Diff 9117!Jun 4 2019, 13:22
teamcity added a comment.Jun 4 2019, 13:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jun 4 2019, 15:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 4 2019, 15:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6135: Diff 9117.Jun 4 2019, 15:46
jasonbcox retitled this revision from Remove implcit parameter from GetSerializeSize to Remove implicit parameter from GetSerializeSize.Jun 4 2019, 20:24
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox accepted this revision.Jun 4 2019, 20:33
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 4 2019, 20:33
Closed by commit rABC3a8bd492d2ee: Remove implicit parameter from GetSerializeSize (authored by deadalnix). · Explain WhyJun 4 2019, 21:28
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3a8bd492d2ee: Remove implicit parameter from GetSerializeSize.
deadalnix added a commit: rSTAGING3a8bd492d2ee: Remove implicit parameter from GetSerializeSize.Sep 19 2019, 00:01

Revision Contents
Changeset List

PathSize
src/
policy/
5 lines
6 lines
test/
48 lines

Diff 9117

View Options

src/policy/policy.cpp

Loading...
View Options

src/serialize.h

Loading...
View Options

src/test/serialize_tests.cpp

Loading...