Page MenuHomePhabricator

Remove implicit parameter from GetSerializeSize
ClosedPublic

Authored by deadalnix on Jun 4 2019, 13:11.

Details

Summary

Both parameters are integer so we can't rely on the type checker to raise errors.

One such error was present in GetVirtualTransactionSize

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
serexplicitparam
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6135
Build 10318: Bitcoin ABC Buildbot (legacy)
Build 10317: arc lint + arc unit

Event Timeline

jasonbcox retitled this revision from Remove implcit parameter from GetSerializeSize to Remove implicit parameter from GetSerializeSize.Jun 4 2019, 20:24
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 4 2019, 20:33