Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3d60470ea3f0: [LINTER] Prevent including a source file
rABC3d60470ea3f0: [LINTER] Prevent including a source file

Summary

This linter detects the #include of *.c ,*.cc or *.cpp file.

Depends on D3333

Test Plan

Modify src/init.cpp to include a *.c, *.cc or *.cpp file.

arc lint -- src/init.cpp

Check the linter detects the inclusion and thrown an error.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 13 2019, 15:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 15:50

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6314: Diff 9400.Jun 13 2019, 15:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

This should also detect the inclusion of a .c .

This revision now requires changes to proceed.Jun 13 2019, 22:24

Has this error actually happened in the wild ? Also, do we need a new linter for each thing that can go wrong with includes ? It seems like one should be enough.

arcanist/linter/IncludeSourceLinter.php
29 ↗	(On Diff #9400)	It seems like this is completely redundant code.
57 ↗	(On Diff #9400)	???

@deadalnix Yes this error did appear:
https://reviews.bitcoinabc.org/D3283?id=9308#inline-20242

I considered having a single linter, but as long as there is no performance penalty (arc linting all takes < 0.5s) I prefer leaving them separated.
It makes the error output more specific (the short error code) and allows for varying file filters individually.

Check for *.c inclusion.
Fix indent.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Jun 14 2019, 12:10

Fabien edited the test plan for this revision. (Show Details)

Fabien added a parent revision: D3333: Avoid including a C file in crypto/aes.cpp.

Harbormaster completed remote builds in B6339: Diff 9432.Jun 14 2019, 12:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added inline comments.Jun 14 2019, 13:18