Page MenuHomePhabricator
Differential D3319

[LINTER] Enforce using angle brackets in #include directives
ClosedPublic
Actions

Authored by Fabien on Jun 13 2019, 16:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGfce74c92e6a6: [LINTER] Enforce using angle brackets in #include directives
rABCfce74c92e6a6: [LINTER] Enforce using angle brackets in #include directives
Summary

This linter throws an error when a #include "header.h" is encountered.

Test Plan

Modify src/init.cpp to use double quotes in a #include directive.

arc lint -- src/init.cpp

Check the linter catches the error.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
include_double_quotes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6315
Build 10677: Bitcoin ABC Buildbot (legacy)
Build 10676: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 13 2019, 16:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 16:07
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 13 2019, 16:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2019, 16:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6315: Diff 9401.Jun 13 2019, 16:13
deadalnix accepted this revision.Jun 13 2019, 22:20
This revision is now accepted and ready to land.Jun 13 2019, 22:20
Fabien updated this revision to Diff 9433.Jun 14 2019, 12:15

Remove useless parent method overriding.

teamcity added a comment.Jun 14 2019, 12:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 12:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6340: Diff 9433.Jun 14 2019, 12:22
Closed by commit rABCfce74c92e6a6: [LINTER] Enforce using angle brackets in #include directives (authored by Fabien). · Explain WhyJun 15 2019, 07:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfce74c92e6a6: [LINTER] Enforce using angle brackets in #include directives.
Fabien added a commit: rSTAGINGfce74c92e6a6: [LINTER] Enforce using angle brackets in #include directives.Sep 19 2019, 00:20

Revision Contents
Changeset List

Diff 9401

View Options

.arclint

Loading...
View Options

arcanist/.phutil_module_cache

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/IncludeQuotesLinter.php

Loading...