Page MenuHomePhabricator
Differential D3337

Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2019, 16:55.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
rABCadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
Summary

This is a backport of Core PR10694

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10694
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6346
Build 10739: Bitcoin ABC Buildbot (legacy)
Build 10738: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 14 2019, 16:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2019, 16:55
teamcity added a comment.Jun 14 2019, 16:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3338: bitcoin-tx: Remove unused for loop.Jun 14 2019, 16:58
teamcity added a comment.Jun 14 2019, 17:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6346: Diff 9448.Jun 14 2019, 17:06
jasonbcox accepted this revision.Jun 14 2019, 22:12
This revision is now accepted and ready to land.Jun 14 2019, 22:12
Closed by commit rABCadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyJun 15 2019, 00:00
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&).
deadalnix added a commit: rSTAGINGadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&).Sep 19 2019, 00:20

Revision Contents
Changeset List

PathSize
src/
13 lines

Diff 9448

View Options

src/bitcoin-tx.cpp

Loading...