Fix mining_prioritisetransaction
ClosedPublic
Actions

Authored by Fabien on Jun 24 2019, 13:57.

Details

Reviewers

deadalnix
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGf06e269e241f: Fix mining_prioritisetransaction
rABCf06e269e241f: Fix mining_prioritisetransaction

Summary

The core PR10196 backported in D3386 is fubared.

Test Plan

./test/functional/test_runner.py mining_prioritisetransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 24 2019, 13:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2019, 13:57

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D3369: Bugfix: PrioritiseTransaction updates the mempool tx counter.Jun 24 2019, 13:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6457: Diff 9607.Jun 24 2019, 14:04

Hmm weird, why is ours called tx2_id?

It is the state of the test before PR9602 https://github.com/bitcoin/bitcoin/commit/0315888d0db2f39c784afac19ff5db5086f30820.

markblundeberg accepted this revision.Jun 24 2019, 16:07

This revision is now accepted and ready to land.Jun 24 2019, 16:07

Closed by commit rABCf06e269e241f: Fix mining_prioritisetransaction (authored by Fabien). · Explain WhyJun 24 2019, 17:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf06e269e241f: Fix mining_prioritisetransaction.

Fabien added a commit: rSTAGINGf06e269e241f: Fix mining_prioritisetransaction.Sep 19 2019, 00:29

Revision Contents
Changeset List

Path

Size

test/

functional/

mining_prioritisetransaction.py

9 lines

Diff 9621

View Options

test/functional/mining_prioritisetransaction.py

Fix mining_prioritisetransactionClosedPublicActions