Don't attempt mempool entry for wallet tx on start if already in mempool
ClosedPublic
Actions

Authored by Fabien on Jun 26 2019, 16:01.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa119e7caf8ab: Don't attempt mempool entry for wallet tx on start if already in mempool
rABCa119e7caf8ab: Don't attempt mempool entry for wallet tx on start if already in mempool

Summary

Mempool loads first, wallet second. Second attempt fails, marking that
transaction !fInMempool. Those funds will disappear until confirmation
is reached.

Backport of core PR11839
https://github.com/bitcoin/bitcoin/pull/11839/files

Test Plan

./test/functional/test_runner.py mempool_persist

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 26 2019, 16:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 26 2019, 16:01

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6496: Diff 9689.Jun 26 2019, 16:07

deadalnix accepted this revision.Jun 26 2019, 23:05

This revision is now accepted and ready to land.Jun 26 2019, 23:05

Closed by commit rABCa119e7caf8ab: Don't attempt mempool entry for wallet tx on start if already in mempool (authored by Gregory Sanders <gsanders87@gmail.com>, committed by Fabien). · Explain WhyJun 27 2019, 07:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa119e7caf8ab: Don't attempt mempool entry for wallet tx on start if already in mempool.

Fabien added a commit: rSTAGINGa119e7caf8ab: Don't attempt mempool entry for wallet tx on start if already in mempool.Sep 19 2019, 00:36

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

5 lines

test/

functional/

mempool_persist.py

12 lines

Diff 9701

View Options

src/wallet/wallet.cpp