HomePhabricator

Don't attempt mempool entry for wallet tx on start if already in mempool

Description

Don't attempt mempool entry for wallet tx on start if already in mempool

Summary:

Mempool loads first, wallet second. Second attempt fails, marking that
transaction !fInMempool. Those funds will disappear until confirmation
is reached.

Backport of core PR11839
https://github.com/bitcoin/bitcoin/pull/11839/files

Test Plan:

./test/functional/test_runner.py mempool_persist

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3425

Details

Provenance
Gregory Sanders <gsanders87@gmail.com>Authored on Dec 6 2017, 17:08
FabienCommitted on Jun 27 2019, 07:55
FabienPushed on Jun 27 2019, 08:50
Reviewer
Restricted Project
Differential Revision
D3425: Don't attempt mempool entry for wallet tx on start if already in mempool
Parents
rSTAGING43c4fc49b8c5: [tests] Combine logs on failure
Branches
Unknown
Tags
Unknown