Page MenuHomePhabricator
Differential D3450

Make unit tests use the insecure_rand_ctx exclusively
ClosedPublic
Actions

Authored by deadalnix on Jun 28 2019, 00:06.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING4f21390dbe60: Make unit tests use the insecure_rand_ctx exclusively
rABC4f21390dbe60: Make unit tests use the insecure_rand_ctx exclusively
Summary

This is a partial backport of Core PR14624 : https://github.com/bitcoin/bitcoin/pull/14624/commits/fd3e7973ffaaa15ed32e5aeadcb02956849b8fc7

Depends on D3437 and D3441

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
randomunittest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6523
Build 11093: Bitcoin ABC Buildbot (legacy)
Build 11092: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 28 2019, 00:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2019, 00:06
teamcity added a comment.Jun 28 2019, 00:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 28 2019, 00:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6523: Diff 9744.Jun 28 2019, 00:15
markblundeberg accepted this revision.Jun 28 2019, 03:36
This revision is now accepted and ready to land.Jun 28 2019, 03:36
deadalnix updated this revision to Diff 9805.Jun 30 2019, 00:05

rebase

teamcity added a comment.Jun 30 2019, 00:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 30 2019, 00:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6558: Diff 9805.Jun 30 2019, 00:11
deadalnix added a child revision: D3485: test: Make g_insecure_rand_ctx thread_local.Jun 30 2019, 22:30
Closed by commit rABC4f21390dbe60: Make unit tests use the insecure_rand_ctx exclusively (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 1 2019, 22:44
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4f21390dbe60: Make unit tests use the insecure_rand_ctx exclusively.
deadalnix added a commit: rSTAGING4f21390dbe60: Make unit tests use the insecure_rand_ctx exclusively.Sep 19 2019, 00:50

Revision Contents
Changeset List

Diff 9744

View Options

src/test/DoS_tests.cpp

Loading...
View Options

src/test/cuckoocache_tests.cpp

Loading...
View Options

src/test/validation_block_tests.cpp

Loading...