Differential D3458

qa: Rename cli.args to cli.options
ClosedPublic
Actions

Authored by Fabien on Jun 28 2019, 13:56.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING67f07b7a3e80: qa: Rename cli.args to cli.options
rABC67f07b7a3e80: qa: Rename cli.args to cli.options

Summary

That is the name in bitcoin-cli -help

Partial backport of core PR12089 (commit ffffb10)
https://github.com/bitcoin/bitcoin/pull/12089/commits/ffffb10a9f12b43d4716048ebfd7203bd79e59f3

Test Plan

./test/functional/test_runner.py wallet_multiwallet

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12089_part1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6531
Build 11109: Bitcoin ABC Buildbot (legacy)
Build 11108: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 28 2019, 13:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2019, 13:56

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3459: qa: Make TestNodeCLI command optional in send_cli.Jun 28 2019, 13:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6531: Diff 9759.Jun 28 2019, 14:02

deadalnix accepted this revision.Jun 28 2019, 14:06

This revision is now accepted and ready to land.Jun 28 2019, 14:06

Closed by commit rABC67f07b7a3e80: qa: Rename cli.args to cli.options (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJun 28 2019, 17:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC67f07b7a3e80: qa: Rename cli.args to cli.options.

Fabien added a commit: rSTAGING67f07b7a3e80: qa: Rename cli.args to cli.options.Sep 19 2019, 00:43

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_node.py

10 lines

Diff 9759

View Options

test/functional/test_framework/test_node.py

qa: Rename cli.args to cli.optionsClosedPublicActions