qa: Make TestNodeCLI command optional in send_cli
ClosedPublic
Actions

Authored by Fabien on Jun 28 2019, 13:58.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3390c37a883d: qa: Make TestNodeCLI command optional in send_cli
rABC3390c37a883d: qa: Make TestNodeCLI command optional in send_cli

Summary

Makes the command optional, since there are valid bitcoin-cli calls that
have no command:

  - bitcoin-cli -?
  - bitcoin-cli -getinfo
  - ...

Partial backport of core PR12089 (commit fae7b14)
https://github.com/bitcoin/bitcoin/pull/12089/commits/fae7b14a0468fba43ca8ce87249be69e13cea608

Depends on D3458

Test Plan

./test/functional/test_runner.py interface_bitcoin_cli

wallet_multiwallet

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12089_part2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6532
Build 11111: Bitcoin ABC Buildbot (legacy)
Build 11110: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 28 2019, 13:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2019, 13:58

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

This is the type of PR you typicaly may want to backport in one piece to reduce the work involved.

This revision is now accepted and ready to land.Jun 28 2019, 14:06

Harbormaster completed remote builds in B6532: Diff 9760.Jun 28 2019, 14:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC3390c37a883d: qa: Make TestNodeCLI command optional in send_cli (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJun 28 2019, 17:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3390c37a883d: qa: Make TestNodeCLI command optional in send_cli.

Fabien added a commit: rSTAGING3390c37a883d: qa: Make TestNodeCLI command optional in send_cli.Sep 19 2019, 00:43

Revision Contents
Changeset List

Path

Size

test/

functional/

interface_bitcoin_cli.py

2 lines

test_framework/

test_node.py

6 lines

Diff 9760

View Options

test/functional/interface_bitcoin_cli.py