Fix a shadow warning in askpassphrasedialog.cpp
ClosedPublic
Actions

Authored by Fabien on Jul 1 2019, 07:31.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGc469b47414cb: Fix a shadow warning in askpassphrasedialog.cpp
rABCc469b47414cb: Fix a shadow warning in askpassphrasedialog.cpp

Summary

The toggleShowPassword method defines a local mode variable,
shadowing the AskPassphraseDialog member.
This diff renames the local variable to renderingMode.

Test Plan

make check

Check the warning is now fixed.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_shadow

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6582
Build 11211: Bitcoin ABC Buildbot (legacy)
Build 11210: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 1 2019, 07:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 07:31

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6582: Diff 9837.Jul 1 2019, 07:38

deadalnix accepted this revision.Jul 1 2019, 12:02

This revision is now accepted and ready to land.Jul 1 2019, 12:02

Closed by commit rABCc469b47414cb: Fix a shadow warning in askpassphrasedialog.cpp (authored by Fabien). · Explain WhyJul 1 2019, 12:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc469b47414cb: Fix a shadow warning in askpassphrasedialog.cpp.

Fabien added a commit: rSTAGINGc469b47414cb: Fix a shadow warning in askpassphrasedialog.cpp.Sep 19 2019, 00:47

Revision Contents
Changeset List

Path

Size

src/

qt/

askpassphrasedialog.cpp

8 lines

Diff 9837

View Options

src/qt/askpassphrasedialog.cpp

Fix a shadow warning in askpassphrasedialog.cppClosedPublicActions