Page MenuHomePhabricator

qa: Prepare functional tests for Windows
ClosedPublic

Authored by Fabien on Jul 1 2019, 13:11.

Details

Summary
* Pass `sys.executable` when calling a python script via the subprocess
  module
* Don't remove the log file while it is still open and written to
* Properly use os.pathsep and os.path.sep when modifying the PATH
  environment variable
* util-tests: Use os.path.join for Windows compatibility

Backport of core PR11858
https://github.com/bitcoin/bitcoin/pull/11858/files

Include a fix from PR12438:
https://github.com/bitcoin/bitcoin/pull/12438/files

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jul 1 2019, 13:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 13:11
Fabien planned changes to this revision.Jul 1 2019, 13:16
Fabien updated this revision to Diff 9851.Jul 1 2019, 13:23

Fix bitcoin-util

Fabien added a comment.Jul 1 2019, 13:45

Note to reviewers: this is not enough to make the tests working on windows

deadalnix accepted this revision.Jul 1 2019, 13:51
This revision is now accepted and ready to land.Jul 1 2019, 13:51
Fabien edited the summary of this revision. (Show Details)Jul 1 2019, 13:54
This revision was automatically updated to reflect the committed changes.