Page MenuHomePhabricator

qa: Prepare functional tests for Windows
ClosedPublic

Authored by Fabien on Jul 1 2019, 13:11.

Details

Summary
* Pass `sys.executable` when calling a python script via the subprocess
  module
* Don't remove the log file while it is still open and written to
* Properly use os.pathsep and os.path.sep when modifying the PATH
  environment variable
* util-tests: Use os.path.join for Windows compatibility

Backport of core PR11858
https://github.com/bitcoin/bitcoin/pull/11858/files

Include a fix from PR12438:
https://github.com/bitcoin/bitcoin/pull/12438/files

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11858
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6588
Build 11223: Bitcoin ABC Buildbot (legacy)
Build 11222: arc lint + arc unit

Event Timeline

Fabien planned changes to this revision.Jul 1 2019, 13:16

Note to reviewers: this is not enough to make the tests working on windows

This revision is now accepted and ready to land.Jul 1 2019, 13:51