Page MenuHomePhabricator

doc: Make build system insert version in Doxyfile
ClosedPublic

Authored by jasonbcox on Jul 1 2019, 21:11.

Details

Summary
Test Plan
make check
ninja
less <build>/doc/Doxyfile # verify it exists and is generated with the correct version number

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Jul 1 2019, 21:11
Fabien requested changes to this revision.Jul 2 2019, 06:10
Fabien added a subscriber: Fabien.

This is breaking the release process for cmake.

This revision now requires changes to proceed.Jul 2 2019, 06:10
jasonbcox updated this revision to Diff 9914.Jul 2 2019, 16:17

Added cmake support

jasonbcox edited the test plan for this revision. (Show Details)Jul 2 2019, 16:18
jasonbcox added inline comments.Jul 2 2019, 16:20
doc/Doxyfile.cmake.in
41 ↗(On Diff #9914)

Autotools defines a PACKAGE_VERSION but the cmake build does not. Since the version may be represented in slightly different ways, it didn't seem correct to define one. Using the appropriate version components here.

doc/Doxyfile.in
35 ↗(On Diff #9914)

This isn't part of the original PR but clearly should have been. No other Core PR covers this, so I included it here.

jasonbcox edited the summary of this revision. (Show Details)Jul 2 2019, 17:25
Fabien requested changes to this revision.Jul 3 2019, 15:13
Fabien added inline comments.
doc/Doxyfile.cmake.in
35 ↗(On Diff #9914)

Prefer the ${VARIABLE} notation which is the default for Cmake, unless you need this notation for something else (e.g. for configuring a bash script).
If you really need to stick with the @VARIABLE@ notation, please add the @ONLY flag to configure_file().

This revision now requires changes to proceed.Jul 3 2019, 15:13
jasonbcox updated this revision to Diff 10099.Jul 8 2019, 17:08

Switched variable style for the cmake config

Fabien accepted this revision.Jul 8 2019, 18:55
This revision is now accepted and ready to land.Jul 8 2019, 18:55