Page MenuHomePhabricator

Backport base58 tests from PR11167
ClosedPublic

Authored by deadalnix on Jul 1 2019, 21:57.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 1 2019, 21:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 21:57
Fabien requested changes to this revision.Jul 2 2019, 06:53
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/base58_tests.cpp
16 ↗(On Diff #9886)

Revert

20 ↗(On Diff #9886)

Dito

206 ↗(On Diff #9886)

As you are looping over the various chains, I don't understand the added in mainnet ?

Edit: https://github.com/bitcoin/bitcoin/pull/11167#discussion_r140595269

209 ↗(On Diff #9886)

Dito

This revision now requires changes to proceed.Jul 2 2019, 06:53
deadalnix updated this revision to Diff 9951.Jul 3 2019, 13:02

Address comments

Fabien accepted this revision.Jul 3 2019, 14:17
This revision is now accepted and ready to land.Jul 3 2019, 14:17
This revision was automatically updated to reflect the committed changes.