Differential D3544

Use AC_ARG_VAR to set ARFLAGS.
ClosedPublic
Actions

Authored by Fabien on Jul 4 2019, 14:48.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING62334e945f4e: Use AC_ARG_VAR to set ARFLAGS.
rABC62334e945f4e: Use AC_ARG_VAR to set ARFLAGS.

Summary

The user can set ARFLAGS in the ./configure step with
  ./configure ARFLAGS=...
If he chooses not to do so, ARFLAGS will be set to cr.

Backport of core PR10766
https://github.com/bitcoin/bitcoin/pull/10766/files

Test Plan

make

Check the warning:

/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')

is no longer displayed after this patch.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10766

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6661
Build 11369: Bitcoin ABC Buildbot (legacy)
Build 11368: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 4 2019, 14:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 14:48

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6661: Diff 9976.Jul 4 2019, 14:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jul 4 2019, 16:11

This revision is now accepted and ready to land.Jul 4 2019, 16:11

Closed by commit rABC62334e945f4e: Use AC_ARG_VAR to set ARFLAGS. (authored by René Nyffenegger <mail@renenyffenegger.ch>, committed by Fabien). · Explain WhyJul 5 2019, 13:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC62334e945f4e: Use AC_ARG_VAR to set ARFLAGS..

Fabien added a commit: rSTAGING62334e945f4e: Use AC_ARG_VAR to set ARFLAGS..Sep 19 2019, 00:57

Revision Contents
Changeset List

Path

Size

configure.ac

7 lines

Diff 9976

View Options

Use AC_ARG_VAR to set ARFLAGS.ClosedPublicActions