Differential D3546

[build] Don't fail when passed --disable-lcov and lcov isn't available
ClosedPublic
Actions

Authored by Fabien on Jul 4 2019, 15:06.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2ba4088b3e51: [build] Don't fail when passed --disable-lcov and lcov isn't available
rABC2ba4088b3e51: [build] Don't fail when passed --disable-lcov and lcov isn't available

Summary

Backport of core PR11611
https://github.com/bitcoin/bitcoin/pull/11611/files

Test Plan

sudo apt remove lcov
./autogen.sh
mkdir build && cd build
../configure --disable-lcov

Check that configure does not fail.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 4 2019, 15:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 15:06

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6663: Diff 9978.Jul 4 2019, 15:17

deadalnix accepted this revision.Jul 4 2019, 16:12

This revision is now accepted and ready to land.Jul 4 2019, 16:12

Closed by commit rABC2ba4088b3e51: [build] Don't fail when passed --disable-lcov and lcov isn't available (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyJul 5 2019, 13:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2ba4088b3e51: [build] Don't fail when passed --disable-lcov and lcov isn't available.

Fabien added a commit: rSTAGING2ba4088b3e51: [build] Don't fail when passed --disable-lcov and lcov isn't available.Sep 19 2019, 00:57

Revision Contents
Changeset List

Path

Size

2 lines

Diff 10007

configure.ac

Loading...