Differential D3566

test: Plug memory leaks and stack-use-after-scope
AbandonedPublic
Actions

Authored by deadalnix on Jul 5 2019, 16:28.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

This is a backport of Core PR12477 . The bench part is irrelevent now that the code is using OutputGroup.

Test Plan

Run

src/test/test_bitcoin -t checkqueue_tests

With both tsan and asan. Verify it is now clean.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

useafterfree

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6686
Build 11419: Bitcoin ABC Buildbot (legacy)
Build 11418: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 5 2019, 16:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 16:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Interesting, subtle use-after-scope there...

Fabien requested changes to this revision.Jul 5 2019, 17:24

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/test_bitcoin.cpp
41	This part will conflict with https://reviews.bitcoinabc.org/D2918 and https://reviews.bitcoinabc.org/D2919 and cause double free (see build failure).

This revision now requires changes to proceed.Jul 5 2019, 17:24

Fixing the DoS test require to get the banman PR backported. looks like this will have to wait.

Fabien mentioned this in D3598: Fix checkqueue_tests use-after-scope.Jul 8 2019, 20:45

Fabien mentioned this in rABCc9911ddd7dc2: Fix checkqueue_tests use-after-scope.Jul 9 2019, 05:56

This is now obsolete

Fabien mentioned this in rSTAGINGc9911ddd7dc2: Fix checkqueue_tests use-after-scope.Sep 19 2019, 01:05

Revision Contents
Changeset List

Path

Size

src/

test/

checkqueue_tests.cpp

8 lines

test_bitcoin.cpp

4 lines

Diff 10013

View Options

src/test/checkqueue_tests.cpp