Page MenuHomePhabricator

Optimize PNG images
ClosedPublic

Authored by Fabien on Jul 9 2019, 06:16.

Details

Summary

This is the result of the contrib/devtools/optimize-pngs.py script.
This saves the grand total of 14819 bytes.

Test Plan

Check the icons are still good-looking.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
optimize_png
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6751
Build 11549: Bitcoin ABC Buildbot (legacy)
Build 11548: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 9 2019, 06:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 06:16
deadalnix requested changes to this revision.Jul 9 2019, 12:16

How come this is changing images we inherited from core ? Second, is this lossy ? If it is, it should not be done on source material.

This revision now requires changes to proceed.Jul 9 2019, 12:16
Fabien requested review of this revision.Jul 9 2019, 12:54

My understanding is that the script doesn't impact the image:
it will optimize the png files, remove various color profiles, remove ancillary chunks (alla) and text chunks (text).
Optimization is done by using the filter with the highest compression method by brute-forcing all the filters. Because PNG is lossless, this doesn't impact the image.

Tested on current core master, the HD images are not optimized, I guess they forgot to run the script.

deadalnix accepted this revision.Jul 9 2019, 17:28
This revision is now accepted and ready to land.Jul 9 2019, 17:28
This revision was automatically updated to reflect the committed changes.