Page MenuHomePhabricator
Differential D3605

Implements a virtual destructor on the BaseRequestHandler class.
ClosedPublic
Actions

Authored by Fabien on Jul 9 2019, 07:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGea2affd451f5: Implements a virtual destructor on the BaseRequestHandler class.
rABCea2affd451f5: Implements a virtual destructor on the BaseRequestHandler class.
Summary
Implements a virtual destructor on the BaseRequestHandler class to
protect against undefined behavior in the event that a derived
BaseRequestHandler class has a destructor and an object of such derived
class is destroyed through a pointer to its base class.

Backport of core PR12050
https://github.com/bitcoin/bitcoin/pull/12050/files

Note: the event described above actually occurs.

Test Plan

Build with Clang and check there is no -Wdelete-non-virtual-dtor
warning.

With ASAN enabled:

./test/functional/test_runner.py interface_bitcoin_cli

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12050
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6752
Build 11551: Bitcoin ABC Buildbot (legacy)
Build 11550: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 9 2019, 07:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 07:22
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 9 2019, 07:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2019, 07:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6752: Diff 10124.Jul 9 2019, 07:28
deadalnix accepted this revision.Jul 9 2019, 12:17

It's actually a good idea to build with -Wdelete-non-virtual-dtor if the compiler supports it.

This revision is now accepted and ready to land.Jul 9 2019, 12:17
Closed by commit rABCea2affd451f5: Implements a virtual destructor on the BaseRequestHandler class. (authored by 251 <13120787+251Labs@users.noreply.github.com>, committed by Fabien). · Explain WhyJul 9 2019, 13:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCea2affd451f5: Implements a virtual destructor on the BaseRequestHandler class..
Fabien added a commit: rSTAGINGea2affd451f5: Implements a virtual destructor on the BaseRequestHandler class..Sep 19 2019, 01:05

Revision Contents
Changeset List

PathSize
src/
1 line

Diff 10124

View Options

src/bitcoin-cli.cpp

Loading...