Page MenuHomePhabricator

Move CheckBlock() call to critical section
ClosedPublic

Authored by Fabien on Tue, Jul 9, 12:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc9b857a42499: Move CheckBlock() call to critical section
Summary
This prevents data race for CBlock::fChecked.

Backport of core PR14841
https://github.com/bitcoin/bitcoin/pull/14841/files

Test Plan

With TSAN enabled:

./src/test/test_bitcoin -t validation_block_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jul 9, 12:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 9, 12:40
deadalnix accepted this revision.Tue, Jul 9, 20:12
This revision is now accepted and ready to land.Tue, Jul 9, 20:12