Use forcednsseed by default prior to the fork
ClosedPublic
Actions

Authored by freetrader on Jul 21 2017, 13:10.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa90257622070: Use forcednsseed by default prior to the fork
rABCa90257622070: Use forcednsseed by default prior to the fork

Summary

Ahead of the fork, UAHF nodes are a small minority on the network
and it is possible that they are not found.
This guarantees that the ABC seeds will be asked, increasing the
chance of connecting to good peers.

Can be disabled later once fork peers are easily found without it.

Test Plan

Repeatedly:

stop node, remove peers.dat
start node
check that ABC peers are connected to via seeders after startup (using getpeerinfo RPC or GUI)

A newly started node should be able to connect to ABC peers very
rapidly.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

default_force_dns_seeds_true

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 554
Build 554: arc lint + arc unit

Event Timeline

freetrader created this revision.Jul 21 2017, 13:10

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 21 2017, 13:10

Harbormaster completed remote builds in B554: Diff 894.Jul 21 2017, 13:10

Update from review comment

Harbormaster completed remote builds in B555: Diff 895.Jul 21 2017, 13:17

deadalnix accepted this revision.Jul 21 2017, 13:18

This revision is now accepted and ready to land.Jul 21 2017, 13:18

Closed by commit rABCa90257622070: Use forcednsseed by default prior to the fork (authored by freetrader, committed by freetrader). · Explain WhyJul 21 2017, 13:21

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D361: Document the change in default value for DNS seed use.Jul 21 2017, 13:45

Revision Contents
Changeset List

Path

Size

src/

net.h

5 lines

Diff 894

View Options

Use forcednsseed by default prior to the forkClosedPublicActions