Page MenuHomePhabricator

[wallet] setup wallet background flushing in WalletInit directly
ClosedPublic

Authored by Fabien on Wed, Jul 10, 09:59.

Details

Summary
WalletInit::Start calls postInitProcess() for each wallet. Previously
each call to postInitProcess() would attempt to schedule wallet
background flushing.

Just start wallet background flushing once from WalletInit::Start().

Partial backport of core PR10740 (commit 470316c)
https://github.com/bitcoin/bitcoin/pull/10740/commits/470316c3bf5ca343d5d66b94839169a4572eceb7

Progress towards T459

Test Plan
make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jul 10, 09:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 10, 09:59
deadalnix accepted this revision.Thu, Jul 11, 01:49
deadalnix added inline comments.
src/wallet/init.cpp
400 ↗(On Diff #10189)

Do you actually need the full trinity here ?

This revision is now accepted and ready to land.Thu, Jul 11, 01:49
Fabien updated this revision to Diff 10240.Thu, Jul 11, 19:47

Remove () from the predicate.