Page MenuHomePhabricator
Differential D3634

wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined.
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2019, 14:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where…
rABC94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where…
Summary

This is a backport of Core PR12785 .

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12785
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6797
Build 11641: Bitcoin ABC Buildbot (legacy)
Build 11640: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2019, 14:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 14:33
teamcity added a comment.Jul 10 2019, 14:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 14:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6797: Diff 10194.Jul 10 2019, 14:40
Fabien requested changes to this revision.Jul 10 2019, 16:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.h
825

Remove (see D3477).

This revision now requires changes to proceed.Jul 10 2019, 16:12
deadalnix added inline comments.Jul 10 2019, 18:00
src/wallet/wallet.h
825

Good catch!

deadalnix updated this revision to Diff 10204.Jul 10 2019, 18:03

Remove mapRequestCount

teamcity added a comment.Jul 10 2019, 18:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Jul 10 2019, 18:05
This revision is now accepted and ready to land.Jul 10 2019, 18:05
This revision was landed with ongoing or failed builds.Jul 10 2019, 18:09
Closed by commit rABC94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where….
Harbormaster completed remote builds in B6802: Diff 10204.Jul 10 2019, 18:14
teamcity added a comment.Jul 10 2019, 18:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a commit: rSTAGING94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where….Sep 19 2019, 01:10

Revision Contents
Changeset List

PathSize
src/
wallet/
56 lines

Diff 10194

View Options

src/wallet/wallet.h

Loading...