Differential D3637

use TxId properly in coincontroldialog
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2019, 17:31.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING2be0a84fdf49: use TxId properly in coincontroldialog
rABC2be0a84fdf49: use TxId properly in coincontroldialog

Summary

As per title. This helps ensuring that TxId is used consistently when constructing COutPoint.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

coincontroltxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6801
Build 11649: Bitcoin ABC Buildbot (legacy)
Build 11648: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2019, 17:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 17:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6801: Diff 10203.Jul 10 2019, 17:42

jasonbcox accepted this revision.Jul 10 2019, 19:59

This revision is now accepted and ready to land.Jul 10 2019, 19:59

Closed by commit rABC2be0a84fdf49: use TxId properly in coincontroldialog (authored by deadalnix). · Explain WhyJul 10 2019, 21:28

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC2be0a84fdf49: use TxId properly in coincontroldialog.

deadalnix added a commit: rSTAGING2be0a84fdf49: use TxId properly in coincontroldialog.Sep 19 2019, 01:10

Revision Contents
Changeset List

Path

Size

src/

qt/

coincontroldialog.h

5 lines

coincontroldialog.cpp

43 lines

Diff 10203

View Options

src/qt/coincontroldialog.h