Fix phpcs warnings for unused function parameters
ClosedPublic
Actions

Authored by Fabien on Jul 24 2019, 14:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGee141863102d: Fix phpcs warnings for unused function parameters
rABCee141863102d: Fix phpcs warnings for unused function parameters

Summary

These warnings have been added in recent phpcs versions.

Test Plan

arc lint --everything

Should return no lint error nor warning.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_phpcs_unused_parameters

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6939
Build 11925: Bitcoin ABC Buildbot (legacy)
Build 11924: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 24 2019, 14:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2019, 14:21

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6939: Diff 10429.Jul 24 2019, 14:27

deadalnix accepted this revision.Jul 24 2019, 17:17

This revision is now accepted and ready to land.Jul 24 2019, 17:17

Closed by commit rABCee141863102d: Fix phpcs warnings for unused function parameters (authored by Fabien). · Explain WhyJul 24 2019, 18:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCee141863102d: Fix phpcs warnings for unused function parameters.

Fabien added a commit: rSTAGINGee141863102d: Fix phpcs warnings for unused function parameters.Sep 19 2019, 01:24

Revision Contents
Changeset List

Path

Size

test/

lint/

phpcs/

bitcoinabc_ruleset.xml

2 lines

Diff 10429

View Options

test/lint/phpcs/bitcoinabc_ruleset.xml

Fix phpcs warnings for unused function parametersClosedPublicActions