Page MenuHomePhabricator
Differential D3727

Format mm files
ClosedPublic
Actions

Authored by deadalnix on Jul 24 2019, 14:34.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe1817cc3607b: Format mm files
rABCe1817cc3607b: Format mm files
Summary

As per title.

Test Plan

Cross compile OSX build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
formatmm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6940
Build 11927: Bitcoin ABC Buildbot (legacy)
Build 11926: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 24 2019, 14:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2019, 14:34
teamcity added a comment.Jul 24 2019, 14:34

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6940: Diff 10431.Jul 24 2019, 14:43
teamcity added a comment.Jul 24 2019, 14:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox requested changes to this revision.Jul 24 2019, 22:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/macdockiconhandler.mm
42

brackets

108

brackets

src/qt/macnotificationhandler.mm
56

s/void//

This revision now requires changes to proceed.Jul 24 2019, 22:33
deadalnix requested review of this revision.Jul 24 2019, 23:38

This is an automated formatting.

jasonbcox accepted this revision.Jul 24 2019, 23:57

As long as it's cleaned up in followup.

This revision is now accepted and ready to land.Jul 24 2019, 23:57
deadalnix updated this revision to Diff 10457.Jul 25 2019, 00:11

rebase

teamcity added a comment.Jul 25 2019, 00:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 00:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6953: Diff 10457.Jul 25 2019, 00:24
Closed by commit rABCe1817cc3607b: Format mm files (authored by deadalnix). · Explain WhyJul 25 2019, 02:08
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe1817cc3607b: Format mm files.
deadalnix added a commit: rSTAGINGe1817cc3607b: Format mm files.Sep 19 2019, 01:26

Revision Contents
Changeset List

PathSize
2 lines
src/
8 lines
qt/
61 lines
55 lines

Diff 10431

View Options

.arclint

Loading...
View Options

src/.clang-format

Loading...
View Options

src/qt/macdockiconhandler.mm

Loading...
View Options

src/qt/macnotificationhandler.mm

Loading...