Paths

Table of Contentst

Differential D3728

Fix bitcoin-cli --version
ClosedPublic
Actions

Authored by deadalnix on Jul 24 2019, 15:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING5ed7e25e5614: Fix bitcoin-cli --version
rABC5ed7e25e5614: Fix bitcoin-cli --version

Summary

By declaring the relevant option.

Note contrib/devtools/gen-manpages.sh relies on this version information.

This is a backport of Core PR13725

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 24 2019, 15:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2019, 15:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6941: Diff 10432!Jul 24 2019, 15:17

Fabien requested changes to this revision.Jul 24 2019, 15:36

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/interface_bitcoin_cli.py
24 ↗	(On Diff #10432)	`Bitcoin Core` => `Bitcoin ABC`

This revision now requires changes to proceed.Jul 24 2019, 15:36

deadalnix added inline comments.Jul 24 2019, 15:58

test/functional/interface_bitcoin_cli.py
24 ↗	(On Diff #10432)	Which begs the question: how did htis test ended up passing at all?

Fabien added inline comments.Jul 24 2019, 16:06

test/functional/interface_bitcoin_cli.py
24 ↗	(On Diff #10432)	He did not :)

Fix the test, and make sure it ran and passes

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6944: Diff 10437.Jul 24 2019, 16:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Jul 25 2019, 06:05

This revision is now accepted and ready to land.Jul 25 2019, 06:05

Closed by commit rABC5ed7e25e5614: Fix bitcoin-cli --version (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyJul 25 2019, 10:30

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC5ed7e25e5614: Fix bitcoin-cli --version.

deadalnix added a commit: rSTAGING5ed7e25e5614: Fix bitcoin-cli --version.Sep 19 2019, 01:26

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

2 lines

test/

functional/

interface_bitcoin_cli.py

3 lines

Diff 10463

View Options

src/bitcoin-cli.cpp