Page MenuHomePhabricator

Fix bitcoin-cli --version
ClosedPublic

Authored by deadalnix on Jul 24 2019, 15:13.

Details

Summary

By declaring the relevant option.

Note contrib/devtools/gen-manpages.sh relies on this version information.

This is a backport of Core PR13725

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Jul 24 2019, 15:36
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/interface_bitcoin_cli.py
24 ↗(On Diff #10432)

Bitcoin Core => Bitcoin ABC

This revision now requires changes to proceed.Jul 24 2019, 15:36
test/functional/interface_bitcoin_cli.py
24 ↗(On Diff #10432)

Which begs the question: how did htis test ended up passing at all?

test/functional/interface_bitcoin_cli.py
24 ↗(On Diff #10432)

He did not :)

Fix the test, and make sure it ran and passes

This revision is now accepted and ready to land.Jul 25 2019, 06:05
This revision was automatically updated to reflect the committed changes.