Page MenuHomePhabricator

Fix bitcoin-cli --version
ClosedPublic

Authored by deadalnix on Wed, Jul 24, 15:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5ed7e25e5614: Fix bitcoin-cli --version
Summary

By declaring the relevant option.

Note contrib/devtools/gen-manpages.sh relies on this version information.

This is a backport of Core PR13725

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Jul 24, 15:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 24, 15:13
Fabien requested changes to this revision.Wed, Jul 24, 15:36
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/interface_bitcoin_cli.py
24 ↗(On Diff #10432)

Bitcoin Core => Bitcoin ABC

This revision now requires changes to proceed.Wed, Jul 24, 15:36
deadalnix added inline comments.Wed, Jul 24, 15:58
test/functional/interface_bitcoin_cli.py
24 ↗(On Diff #10432)

Which begs the question: how did htis test ended up passing at all?

Fabien added inline comments.Wed, Jul 24, 16:06
test/functional/interface_bitcoin_cli.py
24 ↗(On Diff #10432)

He did not :)

deadalnix updated this revision to Diff 10437.Wed, Jul 24, 16:09

Fix the test, and make sure it ran and passes

Fabien accepted this revision.Thu, Jul 25, 06:05
This revision is now accepted and ready to land.Thu, Jul 25, 06:05
This revision was automatically updated to reflect the committed changes.