HomePhabricator

Give an error and exit if there are unknown parameters

Authored by Andrew Chow <achow101-github@achow101.com> on Apr 28 2018, 23:40.

Description

Give an error and exit if there are unknown parameters

Summary:

  • If an unknown option is given via either the command line args or

the conf file, throw an error and exit

Update tests for ArgsManager knowing args

Ignore unknown options in the config file for bitcoin-cli

Fix tests and bitcoin-cli to match actual options used

  • Test gArgs erroring on unknown args
  • Updated linter to reflect the new behavior.

Depends on D3713, D3715 and D3712

This is a backport of Core PR13112

Test Plan:

arc lint --everything
make check
test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3716

Details

Committed
deadalnixJul 24 2019, 15:58
Pushed
deadalnixJul 24 2019, 15:58
Reviewer
Restricted Project
Differential Revision
D3716: Give an error and exit if there are unknown parameters
Parents
rABC07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flagsā€¦
Branches
Unknown
Tags
Unknown