HomePhabricator

[teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags…

Description

[teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags correctly

Summary:
Discovered in our logs: https://build.bitcoinabc.org/viewLog.html?buildId=16886&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildLog&_focus=87#_state=87
(see the malformed configure output: sanitizers = address --disable-ccache)

Test Plan:

CONFIGURE_FLAGS="--with-sanitizers=address --disable-ccache" ./build.sh
# Observe configure output is correct:
configure: running /bin/bash ../../../src/univalue/configure ... '--disable-ccache' ...
configure: running /bin/bash ../../../src/secp256k1/configure ... '--disable-ccache' ...
...
sanitizers    = address

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3721

Details

Provenance
jasonbcoxAuthored on Jul 23 2019, 20:14
jasonbcoxPushed on Jul 24 2019, 15:36
Reviewer
Restricted Project
Differential Revision
D3721: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags correctly
Parents
rABCb3b20c12683a: Add circular dependencies script
Branches
Unknown
Tags
Unknown