Page MenuHomePhabricator
Differential D3721

[teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags correctly
ClosedPublic
Actions

Authored by jasonbcox on Jul 23 2019, 20:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags…
rABC07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags…
Summary

Discovered in our logs: https://build.bitcoinabc.org/viewLog.html?buildId=16886&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildLog&_focus=87#_state=87
(see the malformed configure output: sanitizers = address --disable-ccache)

Test Plan
CONFIGURE_FLAGS="--with-sanitizers=address --disable-ccache" ./build.sh
# Observe configure output is correct:
configure: running /bin/bash ../../../src/univalue/configure ... '--disable-ccache' ...
configure: running /bin/bash ../../../src/secp256k1/configure ... '--disable-ccache' ...
...
sanitizers    = address

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 23 2019, 20:29
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 23 2019, 20:29
teamcity added a comment.Jul 23 2019, 20:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B6926: Diff 10411!Jul 23 2019, 20:31
teamcity added a comment.Jul 23 2019, 20:31

Build Bitcoin-ABC / Diffs / Diff Testing failed.

deadalnix accepted this revision.Jul 23 2019, 22:37
This revision is now accepted and ready to land.Jul 23 2019, 22:37
teamcity added a comment.Jul 24 2019, 00:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 24 2019, 00:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6926: Diff 10411.Jul 24 2019, 00:52
Closed by commit rABC07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags… (authored by jasonbcox). · Explain WhyJul 24 2019, 15:36
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags….
jasonbcox added a commit: rSTAGING07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags….Sep 19 2019, 01:24

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines

Diff 10433

View Options

contrib/teamcity/build.sh

Loading...