Page MenuHomePhabricator

[teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags correctly
ClosedPublic

Authored by jasonbcox on Jul 23 2019, 20:29.

Details

Summary

Discovered in our logs: https://build.bitcoinabc.org/viewLog.html?buildId=16886&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildLog&_focus=87#_state=87
(see the malformed configure output: sanitizers = address --disable-ccache)

Test Plan
CONFIGURE_FLAGS="--with-sanitizers=address --disable-ccache" ./build.sh
# Observe configure output is correct:
configure: running /bin/bash ../../../src/univalue/configure ... '--disable-ccache' ...
configure: running /bin/bash ../../../src/secp256k1/configure ... '--disable-ccache' ...
...
sanitizers    = address

Diff Detail

Repository
rABC Bitcoin ABC
Branch
confflags
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6926
Build 11899: Bitcoin ABC Buildbot (legacy)
Build 11898: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 23 2019, 22:37