Give an error and exit if there are unknown parameters
ClosedPublic
Actions

Authored by deadalnix on Jul 23 2019, 12:20.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc314457a3fdb: Give an error and exit if there are unknown parameters
rABCc314457a3fdb: Give an error and exit if there are unknown parameters

Summary

If an unknown option is given via either the command line args or

the conf file, throw an error and exit

Update tests for ArgsManager knowing args

Ignore unknown options in the config file for bitcoin-cli

Fix tests and bitcoin-cli to match actual options used

Test gArgs erroring on unknown args
Updated linter to reflect the new behavior.

Depends on D3713, D3715 and D3712

This is a backport of Core PR13112

Test Plan

arc lint --everything
make check
test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 23 2019, 12:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2019, 12:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Jul 23 2019, 12:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6918: Diff 10399.Jul 23 2019, 12:29

deadalnix added a child revision: D3718: Replace boost program_options.Jul 23 2019, 15:54

rebase

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6935: Diff 10425.Jul 24 2019, 13:19

Fabien accepted this revision.Jul 24 2019, 15:28

This revision is now accepted and ready to land.Jul 24 2019, 15:28

Closed by commit rABCc314457a3fdb: Give an error and exit if there are unknown parameters (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJul 24 2019, 15:58

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCc314457a3fdb: Give an error and exit if there are unknown parameters.

deadalnix added a commit: rSTAGINGc314457a3fdb: Give an error and exit if there are unknown parameters.Sep 19 2019, 01:24

Fabien mentioned this in D5054: Prevent shared conf files from failing with different available options in different binaries.Jan 27 2020, 08:45

Revision Contents
Changeset List

Path

Size

src/

bench/

11 lines

23 lines

11 lines

14 lines

20 lines

interfaces/

node.h

5 lines

node.cpp

9 lines

qt/

bitcoin.cpp

44 lines

rpc/

test/

server_tests.cpp

11 lines

test/

15 lines

67 lines

18 lines

61 lines

test/

functional/

feature_help.py

13 lines

lint/

check-doc.py

23 lines

Diff 10436

View Options

src/bench/bench_bitcoin.cpp

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/bitcoind.cpp

View Options

src/init.cpp

View Options

src/interfaces/node.h

View Options

src/interfaces/node.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/rpc/test/server_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/util.h

View Options

src/util.cpp

View Options

test/functional/feature_help.py

View Options

Give an error and exit if there are unknown parametersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10436

src/bench/bench_bitcoin.cpp

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoind.cpp

src/init.cpp

src/interfaces/node.h

src/interfaces/node.cpp

src/qt/bitcoin.cpp

src/rpc/test/server_tests.cpp

src/test/getarg_tests.cpp

src/test/util_tests.cpp

src/util.h

src/util.cpp

test/functional/feature_help.py

test/lint/check-doc.py

Give an error and exit if there are unknown parameters
ClosedPublic
Actions

Revision Contents
Changeset List