Page MenuHomePhabricator

Give an error and exit if there are unknown parameters
ClosedPublic

Authored by deadalnix on Jul 23 2019, 12:20.

Details

Summary
  • If an unknown option is given via either the command line args or

the conf file, throw an error and exit

Update tests for ArgsManager knowing args

Ignore unknown options in the config file for bitcoin-cli

Fix tests and bitcoin-cli to match actual options used

  • Test gArgs erroring on unknown args
  • Updated linter to reflect the new behavior.

Depends on D3713, D3715 and D3712

This is a backport of Core PR13112

Test Plan
arc lint --everything
make check
test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 23 2019, 12:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2019, 12:20
deadalnix edited the summary of this revision. (Show Details)Jul 23 2019, 12:20
Fabien accepted this revision.Jul 24 2019, 15:28
This revision is now accepted and ready to land.Jul 24 2019, 15:28