Page MenuHomePhabricator

Give an error and exit if there are unknown parameters
ClosedPublic

Authored by deadalnix on Jul 23 2019, 12:20.

Details

Summary
  • If an unknown option is given via either the command line args or

the conf file, throw an error and exit

Update tests for ArgsManager knowing args

Ignore unknown options in the config file for bitcoin-cli

Fix tests and bitcoin-cli to match actual options used

  • Test gArgs erroring on unknown args
  • Updated linter to reflect the new behavior.

Depends on D3713, D3715 and D3712

This is a backport of Core PR13112

Test Plan
arc lint --everything
make check
test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13112-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6918
Build 11883: Bitcoin ABC Buildbot (legacy)
Build 11882: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 24 2019, 15:28