qa: Avoid checking reject code for now
ClosedPublic
Actions

Authored by Fabien on Jul 25 2019, 19:42.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGfbafd06fc788: qa: Avoid checking reject code for now
rABCfbafd06fc788: qa: Avoid checking reject code for now

Summary

The node will often disconnect before sending a reject code. A more
robust solution would be to read from the debug log.

Backport from core PR13352
https://github.com/bitcoin/bitcoin/pull/13352/files

Should fix the CI spurious p2p_invalid_tx issue.

Test Plan

./test/functional/test_runner.py p2p_invalid_tx

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 25 2019, 19:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2019, 19:42

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Jul 25 2019, 19:44

This revision is now accepted and ready to land.Jul 25 2019, 19:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6972: Diff 10489.Jul 25 2019, 19:49

Closed by commit rABCfbafd06fc788: qa: Avoid checking reject code for now (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJul 25 2019, 19:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfbafd06fc788: qa: Avoid checking reject code for now.

Fabien added a commit: rSTAGINGfbafd06fc788: qa: Avoid checking reject code for now.Sep 19 2019, 01:28

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_invalid_tx.py

8 lines

Diff 10490

View Options

test/functional/p2p_invalid_tx.py

qa: Avoid checking reject code for nowClosedPublicActions