Page MenuHomePhabricator

Add src/rpc/abc.cpp to the files checked by check-rpc-mappings
ClosedPublic

Authored by Fabien on Fri, Jul 26, 09:54.

Details

Summary

Add the Bitcoin-ABC specific RPCs to the check script.

Test Plan

Should return no error:

./test/lint/check-rpc-mappings.py .

Add the following line to the vRPCConvertParams[] table in
src/rpc/client.cpp:

{"setexcessiveblock", 1, "dummy"},

Then:

./test/lint/check-rpc-mappings.py .

Should trigger an error:

setexcessiveblock argument 1 (named dummy in vRPCConvertParams) is not
defined in dispatch table

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Jul 26, 09:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jul 26, 09:54

This doesn't look like it's going to be very useful if thins are working this way as we'll keep forgetting to add files in there.

deadalnix accepted this revision.Mon, Jul 29, 00:32

You should consider changing the script to use a regex or something.

This revision is now accepted and ready to land.Mon, Jul 29, 00:32
Fabien added a comment.Mon, Jul 29, 12:46

Will address in a follow-up