Page MenuHomePhabricator
Differential D3751

Add src/rpc/abc.cpp to the files checked by check-rpc-mappings
ClosedPublic
Actions

Authored by Fabien on Jul 26 2019, 09:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf4733c9f324a: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings
rABCf4733c9f324a: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings
Summary

Add the Bitcoin-ABC specific RPCs to the check script.

Test Plan

Should return no error:

./test/lint/check-rpc-mappings.py .

Add the following line to the vRPCConvertParams[] table in
src/rpc/client.cpp:

{"setexcessiveblock", 1, "dummy"},

Then:

./test/lint/check-rpc-mappings.py .

Should trigger an error:

setexcessiveblock argument 1 (named dummy in vRPCConvertParams) is not
defined in dispatch table

Diff Detail

Repository
rABC Bitcoin ABC
Branch
check_rpc_mappings_add_abc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6979
Build 12005: Bitcoin ABC Buildbot (legacy)
Build 12004: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 26 2019, 09:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2019, 09:54
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 26 2019, 09:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 26 2019, 10:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6979: Diff 10499.Jul 26 2019, 10:00
deadalnix added a comment.Jul 26 2019, 13:53

This doesn't look like it's going to be very useful if thins are working this way as we'll keep forgetting to add files in there.

deadalnix accepted this revision.Jul 29 2019, 00:32

You should consider changing the script to use a regex or something.

This revision is now accepted and ready to land.Jul 29 2019, 00:32
Fabien added a comment.Jul 29 2019, 12:46

Will address in a follow-up

Closed by commit rABCf4733c9f324a: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings (authored by Fabien). · Explain WhyJul 29 2019, 12:47
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf4733c9f324a: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings.
Fabien mentioned this in D3757: Use a regex to determine the list of sources for check-rpc-mappings.Jul 29 2019, 12:51
Fabien mentioned this in rABC54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings.Aug 5 2019, 16:19
Fabien added a commit: rSTAGINGf4733c9f324a: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings.Sep 19 2019, 01:29
Fabien mentioned this in rSTAGING54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings.Sep 19 2019, 01:37

Revision Contents
Changeset List

PathSize
test/
lint/
3 lines

Diff 10499

View Options

test/lint/check-rpc-mappings.py

Loading...