Page MenuHomePhabricator

[LINTER] Integrate check-rpc-mappings to arcanist
ClosedPublic

Authored by Fabien on Fri, Jul 26, 10:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3759162424c5: [LINTER] Integrate check-rpc-mappings to arcanist
Summary

Make the check-rpc-mappings.py linter run with arc lint. This is a
global linter so it will run only once.

Test Plan

Should return no error:

arc lint --everything

Remove the line {"getblock", 1, "verbosity"}, from the table
vRPCConvertParams[] in src/rpc/client.cpp then run

arc lint

Check the linter returns both an error and a warning message.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Jul 26, 10:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jul 26, 10:27
deadalnix accepted this revision.Fri, Jul 26, 13:32
This revision is now accepted and ready to land.Fri, Jul 26, 13:32
This revision was automatically updated to reflect the committed changes.