Page MenuHomePhabricator

[LINTER] Integrate check-rpc-mappings to arcanist
ClosedPublic

Authored by Fabien on Jul 26 2019, 10:27.

Details

Summary

Make the check-rpc-mappings.py linter run with arc lint. This is a
global linter so it will run only once.

Test Plan

Should return no error:

arc lint --everything

Remove the line {"getblock", 1, "verbosity"}, from the table
vRPCConvertParams[] in src/rpc/client.cpp then run

arc lint

Check the linter returns both an error and a warning message.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_rpc_mappings
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6980
Build 12007: Bitcoin ABC Buildbot (legacy)
Build 12006: arc lint + arc unit