[tests] refactor interface_rest.py to avoid code repetition
ClosedPublic
Actions

Authored by Fabien on Jul 30 2019, 08:28.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb91494f0d7c5: [tests] refactor interface_rest.py to avoid code repetition
rABCb91494f0d7c5: [tests] refactor interface_rest.py to avoid code repetition

Summary

Also refactor txout index parsing and formatting.

Partial backport of core PR12766 (commit ad00fbe)
https://github.com/bitcoin/bitcoin/pull/12766/commits/ad00fbed3cfcfe7e921500179183589ac4aad419

Depends on D3767

Test Plan

./test/functional/test_runner.py interface_rest

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12766_part4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6999
Build 12045: Bitcoin ABC Buildbot (legacy)
Build 12044: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 30 2019, 08:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2019, 08:28

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D3769: [tests] only use 2 nodes in interface_rest.py.Jul 30 2019, 08:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6999: Diff 10527.Jul 30 2019, 08:38

deadalnix accepted this revision.Aug 5 2019, 06:09

This revision is now accepted and ready to land.Aug 5 2019, 06:09

Closed by commit rABCb91494f0d7c5: [tests] refactor interface_rest.py to avoid code repetition (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyAug 5 2019, 07:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb91494f0d7c5: [tests] refactor interface_rest.py to avoid code repetition.

Fabien added a commit: rSTAGINGb91494f0d7c5: [tests] refactor interface_rest.py to avoid code repetition.Sep 19 2019, 01:35

Revision Contents
Changeset List

Path

Size

test/

functional/

interface_rest.py

263 lines

Diff 10527

View Options

test/functional/interface_rest.py

[tests] refactor interface_rest.py to avoid code repetitionClosedPublicActions