Page MenuHomePhabricator

bench: Don't return a bool from main
ClosedPublic

Authored by Fabien on Jul 31 2019, 14:21.

Details

Summary
Return `EXIT_SUCCESS` from `main()` on error, not the bool `false`
(introduced in #13112). This is the correct value to return on error,
and also shuts up a clang warning.

Also add a final return for clarity.

Backport of core PR13349
https://github.com/bitcoin/bitcoin/pull/13349/files

Test Plan

With clang:

ninja bench-bitcoin

Ensure there is no -Wmain warning during the build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13349
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7019
Build 12085: Bitcoin ABC Buildbot (legacy)
Build 12084: arc lint + arc unit